Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
ensure dask_cuda.__git_commit__ is populated (#1453)
Installing `dask-cuda` like this: ```shell pip install \ --extra-index-url=https://pypi.anaconda.org/rapidsai-wheels-nightly/simple/ \ 'dask-cuda==25.4.*,>=0.0.0a0' ``` The `__git_commit__` attribute on the main module isn't populated: ```shell python -c "import dask_cuda; print(dask_cuda.__git_commit__)" ``` The way this *should* work is that `rapids-build-backend` writes a file `dask_cuda/GIT_COMMIT` which is then read by this code: https://github.com/rapidsai/dask-cuda/blob/412ef5891f1cca78af48c076e0922874c227b34b/dask_cuda/_version.py#L20-L28 I think that what's happening here is this: * `rapids-build-backend` *is* writing that file * the file is not being packaged, because this project uses `setuptools` + a `MANIFEST.in`, and that `MANIFEST.in` does not include that file This proposes the following: * add `GIT_COMMIT` to `MANIFEST.in` * update RAPIDS-specific pre-commit hooks to their latest versions (not related, but might as well, while we're using a CI run anyway) ## Notes for Reviewers Helpful reference for this... "Controlling files in the distribution" from the `setuptools` docs: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Mike Sarahan (https://github.com/msarahan) - Bradley Dice (https://github.com/bdice) URL: #1453
- Loading branch information