Update tests for Python 3.10 #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
bug
pentschev
added
2 - In Progress
|
xref: #1080 thanks Peter! |
pentschev
added
3 - Ready for Review
quasiben
approved these changes
Jan 18, 2023
|
Thanks @quasiben ! |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because in Python 3.10
asyncio.get_event_loop()does not create an event loop anymore, using synchronousLocalClusterraisesDeprecationWarnings intornado.ioloop.IOLoop. Ideally we should update all tests toasync, the changes here are the minimum necessary to unblock Python 3.10.