Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new rapids-dask-dependency metapackage for managing dask versions #1270

Merged

Conversation

galipremsagar
Copy link
Contributor

Currently dask versions are pinned as part of every release cycle and then unpinned for the next development cycle across all of RAPIDS. This introduces a great deal of churn. To centralize the dependency, we have created a metapackage to manage the required dask version and this PR introduces that metapackage as a dependency of dask-cuda.

xref: rapidsai/cudf#14364

@galipremsagar galipremsagar self-assigned this Nov 7, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner November 7, 2023 18:31
@github-actions github-actions bot added the conda conda issue label Nov 7, 2023
@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 7, 2023
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar .

@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 7, 2023
dependencies.yaml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the ci label Nov 8, 2023
@galipremsagar
Copy link
Contributor Author

cc: @pentschev There seems a single pytest that has been consistently failing - would you be able to look into it?

@pentschev
Copy link
Member

I want to see if rapidsai/ucxx#123 will resolve the issue. If it doesn't let's disable UCXX testing and reenable it in branch-24.02. To disable UCXX testing we will replace the line https://github.com/rapidsai/dask-cuda/blob/branch-23.12/ci/test_python.sh#L58 with:

test -k "not ucxx"

@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Nov 13, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 9a5d06d into rapidsai:branch-23.12 Nov 13, 2023
24 checks passed
@galipremsagar
Copy link
Contributor Author

galipremsagar commented Nov 13, 2023

I want to see if rapidsai/ucxx#123 will resolve the issue. If it doesn't let's disable UCXX testing and reenable it in branch-24.02. To disable UCXX testing we will replace the line https://github.com/rapidsai/dask-cuda/blob/branch-23.12/ci/test_python.sh#L58 with:

test -k "not ucxx"

This time all jobs seems to have passed, but will be happy to add this in a separate PR if you say so

@vyasr
Copy link
Contributor

vyasr commented Nov 14, 2023

I'm adding the skip in #1273, I've seen it fail a few times now.

@vyasr vyasr mentioned this pull request Nov 14, 2023
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
…ns (rapidsai#1270)

Currently dask versions are pinned as part of every release cycle and then unpinned for the next development cycle across all of RAPIDS. This introduces a great deal of churn. To centralize the dependency, we have created a metapackage to manage the required dask version and this PR introduces that metapackage as a dependency of dask-cuda.

xref: rapidsai/cudf#14364

Authors:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

Approvers:
  - Peter Andreas Entschev (https://github.com/pentschev)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#1270
pentschev added a commit to pentschev/dask-cuda that referenced this pull request Oct 10, 2024
UCXX CI tests had been previously disabled due to instabilities, see
rapidsai#1270 (comment),
it should now be much more resilient so we should reenable them in
preparation for the permanent migration to UCXX.
@pentschev pentschev mentioned this pull request Oct 10, 2024
rapids-bot bot pushed a commit that referenced this pull request Oct 14, 2024
UCXX CI tests had been previously disabled due to instabilities, see #1270 (comment), it should now be much more resilient so we should reenable them in preparation for the permanent migration to UCXX.

Authors:
  - Peter Andreas Entschev (https://github.com/pentschev)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #1396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants