-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new rapids-dask-dependency
metapackage for managing dask versions
#1270
Use new rapids-dask-dependency
metapackage for managing dask versions
#1270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @galipremsagar .
cc: @pentschev There seems a single pytest that has been consistently failing - would you be able to look into it? |
I want to see if rapidsai/ucxx#123 will resolve the issue. If it doesn't let's disable UCXX testing and reenable it in branch-24.02. To disable UCXX testing we will replace the line https://github.com/rapidsai/dask-cuda/blob/branch-23.12/ci/test_python.sh#L58 with:
|
/merge |
This time all jobs seems to have passed, but will be happy to add this in a separate PR if you say so |
I'm adding the skip in #1273, I've seen it fail a few times now. |
…ns (rapidsai#1270) Currently dask versions are pinned as part of every release cycle and then unpinned for the next development cycle across all of RAPIDS. This introduces a great deal of churn. To centralize the dependency, we have created a metapackage to manage the required dask version and this PR introduces that metapackage as a dependency of dask-cuda. xref: rapidsai/cudf#14364 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai#1270
UCXX CI tests had been previously disabled due to instabilities, see rapidsai#1270 (comment), it should now be much more resilient so we should reenable them in preparation for the permanent migration to UCXX.
UCXX CI tests had been previously disabled due to instabilities, see #1270 (comment), it should now be much more resilient so we should reenable them in preparation for the permanent migration to UCXX. Authors: - Peter Andreas Entschev (https://github.com/pentschev) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #1396
Currently dask versions are pinned as part of every release cycle and then unpinned for the next development cycle across all of RAPIDS. This introduces a great deal of churn. To centralize the dependency, we have created a metapackage to manage the required dask version and this PR introduces that metapackage as a dependency of dask-cuda.
xref: rapidsai/cudf#14364