Drop Numba DeviceNDArray code for sizeof
#257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-0.13 #257 +/- ##
===============================================
+ Coverage 77.92% 78.09% +0.17%
===============================================
Files 14 14
Lines 983 977 -6
===============================================
- Hits 766 763 -3
+ Misses 217 214 -3
Continue to review full report at Codecov.
|
In Dask 2.9.0, support for computing the `sizeof` of Numba `DeviceNDArray`s was included. So bump our Dask version requirement so that we get this fix. Can drop our own vendored version of this code as a result.
As Dask 2.9.0+ has code for determining `sizeof` for Numba `DeviceNDArray`s, there is no need for us to carry around our own code for this. So go ahead and drop it.
jakirkham
force-pushed
the
drop_numba_sizeof_code
branch
from
ba8f179 to
b9bc27e
Compare
|
Thanks Peter! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #224
As Dask 2.9.0+ has code for determining
sizeoffor NumbaDeviceNDArrays, there is no need for us to carry around our own code for this. So go ahead and drop it.