Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ProxyObject binary operations #458

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Support for ProxyObject binary operations #458

merged 1 commit into from
Dec 2, 2020

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Dec 2, 2020

This PR adds support of less-than, greater-than, equal, etc.

@madsbk madsbk requested a review from a team as a code owner December 2, 2020 13:47
@madsbk madsbk added 3 - Ready for Review Ready for review by team 4 - Needs Reviewer Waiting for reviewer to review or respond non-breaking Non-breaking change python python code needed enhancement labels Dec 2, 2020
@madsbk madsbk added improvement Improvement / enhancement to an existing function and removed 4 - Needs Reviewer Waiting for reviewer to review or respond enhancement labels Dec 2, 2020
@codecov-io
Copy link

codecov-io commented Dec 2, 2020 •
edited
Loading

Codecov Report

Merging #458 (7e58903) into branch-0.17 (5bae37b) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.17     #458      +/-   ##
===============================================
+ Coverage        89.68%   89.80%   +0.11%     
===============================================
  Files               15       15              
  Lines             1096     1108      +12     
===============================================
+ Hits               983      995      +12     
  Misses             113      113
Impacted Files Coverage Δ
dask_cuda/proxy_object.py 86.87% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bae37b...7e58903. Read the comment docs.

@madsbk madsbk added 4 - Needs Reviewer Waiting for reviewer to review or respond and removed 3 - Ready for Review Ready for review by team labels Dec 2, 2020
pentschev
pentschev approved these changes Dec 2, 2020
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @madsbk !

@pentschev pentschev merged commit fb6c892 into rapidsai:branch-0.17 Dec 2, 2020
@jakirkham jakirkham mentioned this pull request Dec 2, 2020
Merged
4 tasks
@pentschev pentschev changed the title ProxyObject support of less-than, greater-than, equal, etc. Support for ProxyObject binary operations Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
4 - Needs Reviewer Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@madsbk @codecov-io @pentschev