Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import cleanup fixture in test_dask_cuda_worker.py #924

Merged
merged 1 commit into from
May 31, 2022

Conversation

pentschev
Copy link
Member

With changes from dask/distributed#6231 , the loop fixture now depends on the cleanup fixture, which must be imported explicitly.

@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels May 31, 2022
@pentschev pentschev requested a review from a team as a code owner May 31, 2022 14:44
@github-actions github-actions bot added the python python code needed label May 31, 2022
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2022

Codecov Report

Merging #924 (daf32be) into branch-22.08 (99add03) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           branch-22.08    #924   +/-   ##
============================================
  Coverage          0.00%   0.00%           
============================================
  Files                16      16           
  Lines              2094    2094           
============================================
  Misses             2094    2094           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99add03...daf32be. Read the comment docs.

@pentschev
Copy link
Member Author

Thanks @galipremsagar and @madsbk !

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2ff3d7 into rapidsai:branch-22.08 May 31, 2022
@pentschev pentschev deleted the cleanup-fixture branch June 23, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants