Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Dask-CloudProvider Azure Installation Command #457

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

melodywang060
Copy link
Contributor

Problem

Currently when trying to install Dask-CloudProvider Azure, I am getting a no matches found error:
image

Quick Fix

After some tweaking and exploration, I tried inserting quotation marks around the package name, and that worked.

Therefore, in this PR I propose adding a sentence in the docs that refers to this potential error and suggests users to add quotation marks if they encounter it.

@melodywang060 melodywang060 requested a review from a team as a code owner October 9, 2024 13:12
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this! Left some comments for your consideration.

In general, anywhere you see an installation requirement that uses shell characters, like these:

pip install dask[cloudprovider]
pip install pandas==2.*
pip install numpy>=1.23,<3.0.0a0

They should be wrapped in single quotes to prevent the shell from assigning special meaning to those characters.

If you see other cases like this in the docs, I'd support adding single quotes to them (does not need to be in this PR though).

@@ -12,6 +12,8 @@ Dask Cloud Provider can be installed via `conda` or `pip`. The Azure-specific ca
$ pip install dask-cloudprovider[azure]
```

Try running `pip install "dask-cloudprovider[azure]"` instead if you encounter a `zsh: no matches found` error.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding another line to the docs, I think it'd be simpler to just add single quotes to the code sample above. That should always work, in any shell. Could you please do that instead?

source/cloud/azure/aks.md Outdated Show resolved Hide resolved
source/cloud/azure/aks.md Outdated Show resolved Hide resolved
melodywang060 and others added 4 commits October 9, 2024 11:25
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Co-authored-by: James Lamb <jaylamb20@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants