Fix kvikio casing and remove unnecessary rmm dependency #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyasr
added
bug
3 tasks
trxcllnt
approved these changes
Nov 4, 2024
KyleFromNVIDIA
approved these changes
Nov 4, 2024
|
Merging without CI passing because there are interdependencies between this PR, rapidsai/cudf#17243, and rapidsai/kvikio#534. |
rapids-bot bot
pushed a commit
to rapidsai/kvikio
that referenced
this pull request
Nov 5, 2024
See rapidsai/devcontainers#414 Authors: - Vyas Ramasubramani (https://github.com/vyasr) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) URL: #534
AyodeAwe
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Nov 6, 2024
## Description <!-- Provide a standalone description of changes in this PR. --> <!-- Reference any issues closed by this PR with "closes #1234". --> <!-- Note: The pull request title will be included in the CHANGELOG. --> The case-sensitive name KvikIO is will throw off `find_package` searches, particularly after rapidsai/devcontainers#414 make the usage consistent in devcontainers. ## Checklist - [x] I am familiar with the [Contributing Guidelines](https://github.com/rapidsai/cudf/blob/HEAD/CONTRIBUTING.md). - [x] New or existing tests cover these changes. - [x] The documentation is up to date with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case-sensitive name
KvikIOis throwing offfind_packagesearches in various places.