Skip to content

Conversation

@vyasr
Copy link
Contributor

@vyasr vyasr commented Jun 10, 2025

@vyasr vyasr requested a review from a team as a code owner June 10, 2025 17:07
@vyasr vyasr requested a review from bdice June 10, 2025 17:07
@vyasr vyasr self-assigned this Jun 10, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Support this change generally, but I think that sed change needs to look a little different.

@vyasr vyasr requested a review from jameslamb June 11, 2025 19:28
bdice
bdice previously requested changes Jun 11, 2025
@vyasr vyasr changed the title Remove dask from default label list Remove dask, pytorch, and nvidia channels Jun 11, 2025
@vyasr vyasr requested a review from bdice June 11, 2025 22:57
@jameslamb
Copy link
Member

jameslamb commented Jun 12, 2025

The arm64, CUDA 12.0.01 build-rapids jobs are all failing, like this:

#12 12.76 error    libmamba Could not solve for environment specs
#12 12.76     The following packages are incompatible
#12 12.76     ├─ cuda-version =12.0 * is requested and can be installed;
#12 12.76     └─ rapids =25.8 * is not installable because it requires
#12 12.76        └─ libcugraph_etl =25.8 *, which requires
#12 12.76           └─ libcudf =25.8 * but there are no viable options
#12 12.76              ├─ libcudf 25.8.0a6 would require
#12 12.76              │  └─ cuda-version >=11,<12.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76              └─ libcudf [25.08.00a330|25.08.00a331|...|25.8.0a6] would require
#12 12.76                 └─ libkvikio =25.8 * but there are no viable options
#12 12.76                    ├─ libkvikio 25.8.0a0 would require
#12 12.76                    │  └─ cuda-version >=11,<12.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                    └─ libkvikio [25.08.00a32|25.08.00a34|...|25.8.0a0] would require
#12 12.76                       └─ libcufile-dev =* * but there are no viable options
#12 12.76                          ├─ libcufile-dev [1.10.0.4|1.10.1.7] would require
#12 12.76                          │  └─ cuda-version >=12.5,<12.6.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                          ├─ libcufile-dev [1.11.0.15|1.11.1.6] would require
#12 12.76                          │  └─ cuda-version >=12.6,<12.7.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                          ├─ libcufile-dev [1.13.0.11|1.13.1.3] would require
#12 12.76                          │  └─ cuda-version >=12.8,<12.9.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                          ├─ libcufile-dev [1.14.0.30|1.14.1.1] would require
#12 12.76                          │  └─ cuda-version >=12.9,<12.10.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                          ├─ libcufile-dev 1.7.2.10 would require
#12 12.76                          │  └─ cuda-version >=12.2,<12.3.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                          ├─ libcufile-dev 1.8.1.2 would require
#12 12.76                          │  └─ cuda-version >=12.3,<12.4.0a0 *, which conflicts with any installable versions previously reported;
#12 12.76                          └─ libcufile-dev [1.9.0.20|1.9.1.3] would require
#12 12.76                             └─ cuda-version >=12.4,<12.5.0a0 *, which conflicts with any installable versions previously reported.

(build link)

My read of that is "there are not libcufile-dev arm64, CUDA 12.0 packages available from the channels we're looking for... maybe we were previously getting those from the nvidia channel".

@vyasr
Copy link
Contributor Author

vyasr commented Jun 12, 2025

Well that's problematic. It means we've been pulling invalid environments so far. cufile packages didn't exist on arm until 12.2, so if we were getting them from nvidia (likely the correct diagnosis) we were getting packages that weren't actually constrained to the right cuda-version. I wonder why we have these though; our cufile dependency should be conditional on the cuda version.

@vyasr
Copy link
Contributor Author

vyasr commented Jun 12, 2025

Ah the problem is kvikio's recipe, not cudf's. I have to look a bit closer to figure out the correct fix here though; kvikio has a tighter connection to cufile than cudf, so I don't know if simply removing the dependency is the right answer here.

@jameslamb
Copy link
Member

Yeah was just going to say... I just looked and see libkvikio has an unconditional runtime dependency on libcufile-dev:

https://github.com/rapidsai/kvikio/blob/6d767f75dc7553065746855e22e3d207a6527a5d/conda/recipes/libkvikio/recipe.yaml#L88

@vyasr
Copy link
Contributor Author

vyasr commented Jun 12, 2025

OK I've put in a temporary patch in rapidsai/kvikio#753 to get around this issue. We'll need a follow up that sets up the correct constraints, probably with a variant build.

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vyasr vyasr dismissed bdice’s stale review June 16, 2025 17:52

Addressed

@vyasr
Copy link
Contributor Author

vyasr commented Jun 16, 2025

/merge

@rapids-bot rapids-bot bot merged commit bb539ac into branch-25.08 Jun 16, 2025
149 of 161 checks passed
@vyasr vyasr deleted the chore/remove_dask_label branch June 16, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants