Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pure Python wheels. #96

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 4, 2024

This improves the handling of pure Python wheels in rapids-package-name. When dealing with pure Python packages, we don't want the Python version or CPU arch to be a part of the package's identifiers.

After this is merged, we can adopt this change across RAPIDS repos for pure wheels like dask-cudf, cuxfilter, etc. and then revert rapidsai/shared-workflows#188.

List of pure packages that need to be updated:

tools/rapids-package-name Outdated Show resolved Hide resolved
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Once this is in we'll need follow-ups in the relevant repos.

tools/rapids-package-name Show resolved Hide resolved
tools/rapids-package-name Outdated Show resolved Hide resolved
@bdice bdice marked this pull request as draft March 4, 2024 18:36
@bdice
Copy link
Contributor Author

bdice commented Mar 4, 2024

Marking as draft until I finish testing with rapidsai/cudf#15223.

@bdice bdice marked this pull request as ready for review March 4, 2024 22:45
@bdice
Copy link
Contributor Author

bdice commented Mar 4, 2024

rapidsai/cudf#15223 succeeded and all looks fine. Artifacts are named without Python/arch versions if you set RAPIDS_PY_WHEEL_PURE="1".

@vyasr Do you want to re-review? I made some substantial changes since you approved. We should be good to merge this with one review.

@bdice bdice requested a review from vyasr March 4, 2024 22:46
tools/rapids-package-name Show resolved Hide resolved
@bdice
Copy link
Contributor Author

bdice commented Mar 5, 2024

/merge

@vyasr vyasr merged commit 6ccaf06 into rapidsai:main Mar 5, 2024
1 check passed
rapids-bot bot pushed a commit to rapidsai/cudf that referenced this pull request Mar 6, 2024
This marks `dask-cudf` as a pure wheel, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #15223
rapids-bot bot pushed a commit to rapidsai/cuxfilter that referenced this pull request Mar 6, 2024
This marks `cuxfilter` as a pure wheel, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Jake Awe (https://github.com/AyodeAwe)

URL: #577
vyasr pushed a commit to rapidsai/rapids-dask-dependency that referenced this pull request Mar 7, 2024
## Description
This marks `rapids-dask-dependency` as a pure wheel, meaning that the CI
artifacts are not specific to a Python version or CPU architecture. This
change depends on rapidsai/gha-tools#96, and
makes CI workflows more robust by allowing the test matrix to be
separated from the build matrix.
rapids-bot bot pushed a commit to rapidsai/cugraph that referenced this pull request Mar 7, 2024
…I artifacts as pure wheels (#4216)

This marks `nx-cugraph`, `cugraph-dgl`, `cugraph-pyg`, and `cugraph-equivariant` as pure wheels, meaning that the CI artifacts are not specific to a Python version or CPU architecture. This change depends on rapidsai/gha-tools#96, and makes CI workflows more robust by allowing the test matrix to be separated from the build matrix.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: #4216
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants