Continue to make KvikIO a shared library by moving code from hpp to cpp #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kingcrimsontianyu
added
non-breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
|
/ok to test |
|
/ok to test |
kingcrimsontianyu
added
breaking
|
/ok to test |
KyleFromNVIDIA
approved these changes
Jan 9, 2025
madsbk
reviewed
Jan 9, 2025
madsbk
approved these changes
Jan 13, 2025
3 tasks
|
/merge |
bdice
reviewed
Jan 14, 2025
| "src/posix_io.cpp" | ||
| "src/shim/cuda.cpp" | ||
| "src/shim/cufile.cpp" | ||
| "src/shim/libcurl.cpp" |
There was a problem hiding this comment.
I think libcurl.cpp should only be built if we have an option like CUDF_KVIKIO_REMOTE_IO=ON to enable it. Perhaps it should be named KVIKIO_REMOTE_IO? See NVIDIA/spark-rapids-jni#2766. No curl dependency should be required if that CMake option is off.
There was a problem hiding this comment.
The option I am looking for may already exist: KvikIO_REMOTE_SUPPORT
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jan 14, 2025
KvikIO has just introduced slightly breaking code changes (rapidsai/kvikio#581) where the utility function `getenv_or` is moved out of the `detail` namespace and becomes part of the public API. This PR adapts cuDF for this change. This PR has been tested locally using the abovementioned KvikIO branch. Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Devavret Makkar (https://github.com/devavret) - Bradley Dice (https://github.com/bdice) - Muhammad Haseeb (https://github.com/mhaseeb123) URL: #17733
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 14, 2025
This PR fixes a CMake bug introduced in #581 where `libcurl` is unconditionally compiled. Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Bradley Dice (https://github.com/bdice) - Alessandro Bellina (https://github.com/abellina) URL: #587
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
…Mark noexcept to compat mode-related functions (#588) This PR performs makes the following three improvements: - Separates interface and definition for `file_handle.hpp` that was missed in the previous PR #581. - To help avoid UB (e.g. program crash) for downstream applications, adds the following qualifying remark to the returned future object of `pread/pwrite`: >The `std::future` object's `wait()` or `get()` should not be called after the lifetime of the FileHandle object ends. Otherwise, the behavior is undefined. - Add `noexcept` specifier to compatibility mode-related functions. Authors: - Tianyu Liu (https://github.com/kingcrimsontianyu) Approvers: - Mads R. B. Kristensen (https://github.com/madsbk) - Lawrence Mitchell (https://github.com/wence-) URL: #588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In light of the initiative to make KvikiIO a shared library, this PR further separates the implementation from the interface as thoroughly as possible.
This PR is marked "breaking" because:
getenv_orinitially in thedetailnamespace has been moved outside to become part of the public API. cuDF uses this function and needs a timely code update.detailnamespace for internal use only have been relocated to the.cppfiles, so downstream applications that happen to use those entities will now see compile errors.Notes:
[[nodiscard]]in the header now have them in the declaration (.hpp) only, not in the definition (.cpp).detailnamespace fromX.hppare now moved to the unnamed namespace in theX.cppfiles, unless they are used elsewhere (e.g.Y.cpp).