-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require CMake 3.30.4 #635
Require CMake 3.30.4 #635
Conversation
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on my understanding of rapidsai/rapids-cmake#753
It would be helpful to have a tracking issue similar to rapidsai/build-planning#80 linking all these PRs together and with documentation for why we're doing this. Or rapidsai/rapids-cmake#680 could even become that.
I have made rapidsai/build-planning#154 to track RAPIDS wide status |
/merge |
@robertmaynard The newest CMake Maven plugin I see is version I'm not sure if we can update to 3.30.4 until that is updated. |
I filed an issue on the upstream repository (since Google Code no longer exists, this appears to be the current source): cmake-maven-plugin/cmake-maven-plugin#68 |
I don't think that will block us. It supports using an local install of CMake ( https://github.com/cmake-maven-project/cmake-maven-project/blob/master/README.md#using-a-local-cmake-installation ) and not downloading the tightly coupled version. |
/merge |
Description
Update CMake minimum required to 3.30.4 across all of RAPIDS