Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require CMake 3.30.4 #635

Merged
merged 8 commits into from
Feb 22, 2025
Merged

Conversation

robertmaynard
Copy link
Contributor

Description

Update CMake minimum required to 3.30.4 across all of RAPIDS

@robertmaynard robertmaynard added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Feb 13, 2025
Copy link

copy-pr-bot bot commented Feb 13, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@robertmaynard robertmaynard marked this pull request as ready for review February 14, 2025 17:49
@robertmaynard robertmaynard requested review from a team as code owners February 14, 2025 17:49
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on my understanding of rapidsai/rapids-cmake#753

It would be helpful to have a tracking issue similar to rapidsai/build-planning#80 linking all these PRs together and with documentation for why we're doing this. Or rapidsai/rapids-cmake#680 could even become that.

@robertmaynard
Copy link
Contributor Author

I have made rapidsai/build-planning#154 to track RAPIDS wide status

@bdice
Copy link
Contributor

bdice commented Feb 21, 2025

/merge

@bdice
Copy link
Contributor

bdice commented Feb 21, 2025

@robertmaynard The newest CMake Maven plugin I see is version 3.30.2-b1. https://repo.maven.apache.org/maven2/com/googlecode/cmake-maven-project/cmake-maven-plugin/

I'm not sure if we can update to 3.30.4 until that is updated.

@bdice
Copy link
Contributor

bdice commented Feb 21, 2025

I filed an issue on the upstream repository (since Google Code no longer exists, this appears to be the current source): cmake-maven-plugin/cmake-maven-plugin#68

@robertmaynard
Copy link
Contributor Author

@robertmaynard The newest CMake Maven plugin I see is version 3.30.2-b1. https://repo.maven.apache.org/maven2/com/googlecode/cmake-maven-project/cmake-maven-plugin/

I'm not sure if we can update to 3.30.4 until that is updated.

I don't think that will block us. It supports using an local install of CMake ( https://github.com/cmake-maven-project/cmake-maven-project/blob/master/README.md#using-a-local-cmake-installation ) and not downloading the tightly coupled version.

@bdice
Copy link
Contributor

bdice commented Feb 22, 2025

/merge

@rapids-bot rapids-bot bot merged commit 637cac5 into rapidsai:branch-25.04 Feb 22, 2025
61 checks passed
@robertmaynard robertmaynard deleted the cmake-pin branch February 22, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants