Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental version of leiden_communities #50

Open
wants to merge 2 commits into
base: branch-24.12
Choose a base branch
from

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Nov 22, 2024

This function is not yet defined or implemented in NetworkX, and there is high probability the API may change once added to NetworkX. For now, this is "best effort" and simply mimics PLC leiden.

This function is not yet defined or implemented in NetworkX, and
there is high probability the API may change once added to NetworkX.
@eriknw eriknw added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 22, 2024
@eriknw
Copy link
Contributor Author

eriknw commented Nov 27, 2024

It appears that theta parameter is not used, so I removed it for now.

First, it is ignored in the C->Python API here:
https://github.com/rapidsai/cugraph/blob/1f1cace91e9b97c11dc6d57026360c3a0a919676/cpp/src/c_api/leiden.cpp#L128-L141

Second, it is ignored in the refinement step here (done in rapidsai/cugraph#3990):
https://github.com/rapidsai/cugraph/blob/1f1cace91e9b97c11dc6d57026360c3a0a919676/cpp/src/community/detail/refine_impl.cuh#L107-L124

@eriknw
Copy link
Contributor Author

eriknw commented Nov 27, 2024

Begin adding to networkx here: networkx/networkx#7743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant