Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Consider adding an instantiation of raft::linkage::connect_components #1447

Open
ahendriksen opened this issue Apr 21, 2023 · 0 comments
Labels
feature request New feature or request

Comments

@ahendriksen
Copy link
Contributor

ahendriksen commented Apr 21, 2023

Is your feature request related to a problem? Please describe.

The raft::linkage::connect_components uses fused_l2_nn with a custom operation. This is not instantiated in libraft.so. This was brought up in PR #1439 (5171de3#r1173625212)

Describe the solution you'd like
Options:

  • Add an instantiation for raft::linkage::connect_components in libraft.so
  • Instantiate fused_l2_nn in the test for raft::linkage::connect_components in a separate source file (to make the tests compile fast)

Describe alternatives you've considered

Additional context
Discussion:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant