[ENH] [3/5] Header structure: force explicit instantiation in tests and benchmarks #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the specializations in sub-directories, the raft_runtime source files now mimic the include/ directory hierarchy.
Used .data() instead of .data_handle()
These types are not used in the ext header, but are useful to have.
Under multiple combinations of RAFT_EXPLICIT_INSTANTIATE_ONLY and RAFT_COMPILED
|
Reviewer tip: this PR is a follow up to PR #1438. Only the last 9 commits are part of this PR. That should reduce the diff considerably. |
ahendriksen
changed the title
This was referenced Apr 20, 2023
ahendriksen
added
improvement
ahendriksen
commented
Apr 21, 2023
ahendriksen
commented
Apr 21, 2023
ahendriksen
commented
Apr 21, 2023
tfeher
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Thanks @ahendriksen for the PR. Looks good overall, just have one question.
tfeher
approved these changes
Apr 26, 2023
divyegala
reviewed
Apr 26, 2023
divyegala
reviewed
Apr 26, 2023
divyegala
reviewed
Apr 26, 2023
divyegala
reviewed
Apr 26, 2023
Co-authored-by: Divye Gala <divyegala@gmail.com>
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
This is a rebase of all the commits in PRs: - #1437 - #1438 - #1439 - #1440 - #1441 The original PRs have not been rebased to preserve review comments. This PR is up to date with branch 23.06. Closes #1416 Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) URL: #1469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR #1437, expensive templates can be marked as
RAFT_EXPLICITto indicate they must be explicitly instantiated. This PR forces the tests and benchmarks to use these explicit instantiations.In addition, this PR adds tests to make sure that the header files that provide the expensive templates include all necessary files when compiled under different combinations of
RAFT_EXPLICITandRAFT_EXPLICIT_INSTANTIATE_ONLY. This is done in the following steps:1. Fix tests so that they can be built with
RAFT_EXPLICIT_INSTANTIATE_ONLYdefined.Change the index type in the tests to match the instantiated index type:
Add an instance in the tests in a separate source file:
Allow creating instances in the test itself: (filed issues #1447, #1448)
2. Force explicit instantiation in the benchmarks and tests in CMake:
3. Add tests to make sure that the headers work under all prevalent combinations of
RAFT_COMPILEDandRAFT_EXPLICIT_INSTANTIATE_ONLY: