[PoC] select_k: Replace specialization by split header #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because the raft_runtime source files can sometimes be in the same place as where the template instantiation files will be.
ahendriksen
added
enhancement
ahendriksen
force-pushed
the
poc-inl-headers
branch
from
bc7bea4 to
12f8675
Compare
This commit does not compile, but it preserves the history for select_k.cuh
ahendriksen
force-pushed
the
poc-inl-headers
branch
from
12f8675 to
ee8d78b
Compare
ahendriksen
force-pushed
the
poc-inl-headers
branch
from
24f0308 to
4b3c4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proof of concept of issue #1416 and is more approachable than PR #1415.
It splits the headers of
matrix/select_k.cuhand removes the specializations.