-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] [2/5] Header structure: remove specialization includes #1438
[ENH] [2/5] Header structure: remove specialization includes #1438
Conversation
Instead of having the specializations in sub-directories, the raft_runtime source files now mimic the include/ directory hierarchy.
Used .data() instead of .data_handle()
These types are not used in the ext header, but are useful to have.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviwed the last commit, looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending changes in #1437. I verified all of the existing specializations.cuh
files (and specializations not in detail
directories were indeed deprecated).
This is a rebase of all the commits in PRs: - #1437 - #1438 - #1439 - #1440 - #1441 The original PRs have not been rebased to preserve review comments. This PR is up to date with branch 23.06. Closes #1416 Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) URL: #1469
Specializations are deprecated in PR #1437 . This PR removes includes of these deprecated headers.
On top of PR #1437, it adds a single commit: