[ENH] [5/5] Header structure: isolate logger and memory pool #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the specializations in sub-directories, the raft_runtime source files now mimic the include/ directory hierarchy.
Used .data() instead of .data_handle()
These types are not used in the ext header, but are useful to have.
Under multiple combinations of RAFT_EXPLICIT_INSTANTIATE_ONLY and RAFT_COMPILED
The compute_similarity and interleaved_scan kernel are quite expensive to compile. Splitting the headers in this commit.
These two include files are likely to transitively include spdlog, which increases compilation times.
This was referenced Apr 20, 2023
ahendriksen
added
improvement
|
Note the difference in CI time for this PR compared to the first on in the series:
|
This was referenced Apr 25, 2023
tfeher
approved these changes
Apr 25, 2023
divyegala
reviewed
Apr 26, 2023
cjnolet
requested changes
Apr 26, 2023
There was a problem hiding this comment.
Sorry, @ahendriksen, I looked a little more closely at the macros and I'd like to consolidate these so we don't end up with too much duplication for these core bits. Otherwise, I think this looks great.
cjnolet
reviewed
Apr 26, 2023
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 28, 2023
This is a rebase of all the commits in PRs: - #1437 - #1438 - #1439 - #1440 - #1441 The original PRs have not been rebased to preserve review comments. This PR is up to date with branch 23.06. Closes #1416 Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Divye Gala (https://github.com/divyegala) - Corey J. Nolet (https://github.com/cjnolet) URL: #1469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates the logger and memory pool. These are likely to transitively include spdlog, which slows down compile times. After rapidsai/rmm#1241 is merged, this will yield a substantial improvement in compile times for smaller translation units.
It is a follow up to PR #1440.