Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAGRA support arbitrary dim (number of features) #1458

Closed
Tracked by #1392
tfeher opened this issue Apr 24, 2023 · 0 comments · Fixed by #1505
Closed
Tracked by #1392

CAGRA support arbitrary dim (number of features) #1458

tfeher opened this issue Apr 24, 2023 · 0 comments · Fixed by #1505

Comments

@tfeher
Copy link
Contributor

tfeher commented Apr 24, 2023

No description provided.

@tfeher tfeher mentioned this issue Apr 24, 2023
Open
16 tasks
@tfeher tfeher changed the title support arbitrary dim (number of features) CAGRA support arbitrary dim (number of features) Apr 24, 2023
@tfeher tfeher mentioned this issue May 10, 2023
Merged
@rapids-bot rapids-bot bot closed this as completed in #1505 Jun 9, 2023
rapids-bot bot pushed a commit that referenced this issue Jun 9, 2023
@tfeher
CAGRA pad dataset for 128bit vectorized load (#1505)
6ec78e9 
This PR adds padding to the dataset (if necessary) to make reading any of its rows compatible with 128bit vectorized loads. This change also enables handling arbitrary number of input features (before this PR each row had to be at least 64bit aligned, which constrained the acceptable number of input features).

Fixes #1458.

With this change, it is sufficient to keep a single "load type" specialization for the search kernels, which shall cut the binary size by half (#1459).

Authors:
  - Tamas Bela Feher (https://github.com/tfeher)

Approvers:
  - tsuki (https://github.com/enp1s0)
  - Corey J. Nolet (https://github.com/cjnolet)

URL: #1505
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CAGRA pad dataset for 128bit vectorized load tfeher/raft
1 participant
@tfeher