Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compose CAGRA from RAFT primitives/helpers #1604

Open
Tracked by #1392
cjnolet opened this issue Jun 22, 2023 · 1 comment
Open
Tracked by #1392

Compose CAGRA from RAFT primitives/helpers #1604

cjnolet opened this issue Jun 22, 2023 · 1 comment
Labels
Vector Search

Comments

@cjnolet
Copy link
Member

cjnolet commented Jun 22, 2023 •
edited
Loading

Wherever possible, CAGRA should be composed of RAFT primitives/helpers. If some bits are truly not reusable or cannot be composed of existing RAFT APIs then they can stay in CAGRA's impl details.
@cjnolet cjnolet mentioned this issue Jun 22, 2023
Open
16 tasks
@cjnolet cjnolet changed the title use raft helpers / prims where applicable Compose CAGRA from RAFT primitives/helpers Jun 22, 2023
@cjnolet cjnolet mentioned this issue Jun 22, 2023
Closed
9 tasks
@tfeher
Copy link
Contributor

tfeher commented Jul 19, 2023

Note that we had some PRs addressing the issues: #1550, #1503, #1499. We shall have a review to check if there are additional things to do (apart from the top-k kernels which are tracked separately in #1603).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Vector Search
Projects
VS/ML/DM Primitives Release Board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjnolet @tfeher