-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Un-scale output distances #1499
Un-scale output distances #1499
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Artem for the fix, just a minor thing, otherwise it looks good to me.
Tagging @enp1s0 for visibility.
Co-authored-by: Tamas Bela Feher <tfeher@nvidia.com>
/merge |
It looks like this PR increased the binary size of raft_conda_cpp_cuda11_x86_64.tar.gz by 100MB (from 650MB to 750MB).
Does anybody understand why? It is a significant enough change that might be worth investigating. EDIT: I just noticed that the binary sizes of the rapids-nightly channel are substantially smaller (~250MB). This might be due to bz2 compression. |
Ah yes, that makes sense. I also don't see an increase in the wheels. Thanks for pointing out! |
Reverts the scaling of input data and queries that normally happens for int8/uint8 types before distance computation.
Reuses the ivf-pq post-processing step for that.
Along the way, replaces the custom
fragment_scale
helper with theutils::mapping
that is shared among several ANN methods.Solves #1457