Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Make new lanczos gtests more robust to varying cuda runtime versions #2519

Open
cjnolet opened this issue Dec 5, 2024 · 1 comment
Open

[BUG] Make new lanczos gtests more robust to varying cuda runtime versions #2519

cjnolet opened this issue Dec 5, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@cjnolet
Copy link
Member

cjnolet commented Dec 5, 2024

Release 24.12 brings with it a new and improved lanczos solver, but there are some gtests which are failing because the expected results have been hardcoded while other tests use generated data. The hard-coded data is causing issues, and we should remove it, however we need to make sure the test coverage doesn't change significantly when we remove it.
@cjnolet cjnolet added the bug Something isn't working label Dec 5, 2024
@cjnolet cjnolet mentioned this issue Dec 5, 2024
Merged
AyodeAwe pushed a commit that referenced this issue Dec 6, 2024
@cjnolet
Skip gtests for new lanczos solver when CUDA version is 11.4 or below. (
0af5afb 
#2520)

Medium- to longer term, we plan to fix this issue (ref:
#2519).
@vyasr
Copy link
Contributor

vyasr commented Dec 9, 2024

Based on the need for #2525, the issue may be broader than just hardcoded values not being exactly reproducible on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
VS/ML/DM Primitives Release Board
Status: No status
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cjnolet @vyasr