Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Add randomized svd from cusolver #1000

Merged
merged 47 commits into from
May 22, 2023
Merged

[FEA] Add randomized svd from cusolver #1000

merged 47 commits into from
May 22, 2023

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Nov 9, 2022

No description provided.

@lowener lowener changed the title [FEA] Use randomized svd from cusolver [FEA] Add randomized svd from cusolver Nov 9, 2022
cjnolet
cjnolet requested changes Nov 16, 2022
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely happy to see this getting wrapped within the RAFT APIs. It's been a long time coming. Just a few fairly minor things.

cpp/include/raft/linalg/detail/rsvd.cuh Outdated Show resolved Hide resolved
cpp/include/raft/linalg/rsvd.cuh Outdated Show resolved Hide resolved
cpp/include/raft/linalg/rsvd.cuh Outdated Show resolved Hide resolved
cpp/test/linalg/randomized_svd.cu Show resolved Hide resolved
@cjnolet cjnolet marked this pull request as ready for review November 23, 2022 21:57
@cjnolet cjnolet requested review from a team as code owners November 23, 2022 21:57
@lowener lowener requested a review from cjnolet November 28, 2022 16:55
@cjnolet
Copy link
Member

cjnolet commented Nov 28, 2022

@lowener so you mind retargeting this to 23.02?

@lowener lowener changed the base branch from branch-22.12 to branch-23.02 November 28, 2022 17:15
@lowener lowener requested review from a team as code owners November 28, 2022 17:15
@cjnolet cjnolet changed the base branch from branch-23.02 to branch-23.04 March 9, 2023 03:29
@cjnolet
Copy link
Member

cjnolet commented May 15, 2023

@lowener, it would be great to finally get this merged for 23.06. Can you open a PR to cuml to verify these changes?

@lowener lowener changed the base branch from branch-23.04 to branch-23.06 May 16, 2023 12:35
@lowener lowener mentioned this pull request May 16, 2023
Closed
@lowener lowener added non-breaking Non-breaking change and removed breaking Breaking change labels May 18, 2023
@cjnolet
Copy link
Member

cjnolet commented May 22, 2023

/merge

@rapids-bot rapids-bot bot merged commit a9dd440 into rapidsai:branch-23.06 May 22, 2023
@lowener lowener deleted the 22.10-rsvd branch May 22, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@lowener lowener

Labels
CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lowener @cjnolet @ajschmidt8 @codecov-commenter