Sparse KNN improvements

[viclafargue]

Answers #1187

[codecov-commenter]

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@a850726). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files

@@               Coverage Diff               @@
##             branch-23.04    #1197   +/-   ##
===============================================
  Coverage                ?   87.99%           
===============================================
  Files                   ?       21           
  Lines                   ?      483           
  Branches                ?        0           
===============================================
  Hits                    ?      425           
  Misses                  ?       58           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[cjnolet]

@viclafargue this is a breaking change for users downstream. Do we have a corresponding PR w/ cuML to test these changes?

[viclafargue]

@viclafargue this is a breaking change for users downstream. Do we have a corresponding PR w/ cuML to test these changes?

Thanks for reminding me of this, I will be working on it. But, this PR is far from finished and probably won't be part of the 23.04 release.

[cjnolet]

Thanks for reminding me of this, I will be working on it. But, this PR is far from finished and probably won't be part of the 23.04 release.

Sounds good. I'll mark it for 23.06. Thanks!

[cjnolet]

@viclafargue how are we feeling about these changes for 23.06?

[viclafargue]

@viclafargue how are we feeling about these changes for 23.06?

The PR would need a bit more work at the moment. I don't know if it could be part of 23.06.

[cjnolet]

@viclafargue, sounds good, I'll push to 23.08.