-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add end-to-end CUDA ann-benchmarks to raft #1304
Add end-to-end CUDA ann-benchmarks to raft #1304
Conversation
@benfred the docs for the ann benchmarks might have been collapsed when you were reviewing. At least I found them hard to find when viewing the changes in Github and I knew what I was looking for. Does this file, which we're adding to the docs, help alleviate this concern? Or are you wanting us to either duplicate or point right to to the table of datasets in the (And I also just realized I still had a couple todos in there. I'll fix those before we merge this) |
yup, that looks good! I must have missed it there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Corey for the updates on this PR. It looks good to me, just two minor comment, that can be addressed in the follow-up as well.
/merge |
Replace CUDA_TRY with RAFT_CUDA_TRY in three files. Also replaced CHECK_CUDA with RAFT_CHECK_CUDA rapidsai/raft#1304 removed the old macros, we still had a few references. Currently blocked by rapidsai/cugraph-ops#448... once that is merged we should be able to finish building and merge this. Authors: - Naim (https://github.com/naimnv) - Chuck Hastings (https://github.com/ChuckHastings) Approvers: - Seunghwa Kang (https://github.com/seunghwak) - Chuck Hastings (https://github.com/ChuckHastings) URL: #3389
Was it intended behavior that the benchmarks are not built anymore when you build with |
In any case, I have attempted a fix in #1389. |
Due to some typos in #1304, the benchmarks are not built any more. I have fixed this in this PR. I think it is important that this PR goes into 23.04, otherwise we will not have benchmarks for two months in the stable release. Authors: - Allard Hendriksen (https://github.com/ahendriksen) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: #1389
New
bench/ann
artifact for comparing (C++ APIs for) GPU-acclerated algorithms end-to-end. Working on this w/ @tfeher but had to squash the original commits into a single commit.Things left to do:
benchmarks
executables for each different algorithmggnn
andhnswlib
bench/ann
docsfactory.cuh
abdbenchmark.cu
/benchmark.cpp
into individual files for each different algorithm to make it easier to plug in new algorithms.closes #1211