Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass minimum target compile options through raft::raft #1341

Merged
merged 6 commits into from
Mar 15, 2023
Merged

Pass minimum target compile options through raft::raft #1341

merged 6 commits into from
Mar 15, 2023

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Mar 14, 2023 •
edited
Loading

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 14, 2023
@cjnolet cjnolet self-assigned this Mar 14, 2023
@cjnolet cjnolet marked this pull request as ready for review March 14, 2023 19:30
@cjnolet cjnolet requested a review from a team as a code owner March 14, 2023 19:30
robertmaynard
robertmaynard requested changes Mar 14, 2023
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cjnolet and others added 3 commits March 14, 2023 16:05
@cjnolet @robertmaynard
Update cpp/CMakeLists.txt
ad2d3f0 
Co-authored-by: Robert Maynard <robertjmaynard@gmail.com>
@cjnolet
Changing public->interface
c05851b
@cjnolet
Merge branch 'build-2304-compiler_features' of github.com:cjnolet/raf…
188d274 
…t into build-2304-compiler_features
@cjnolet
Copy link
Member Author

cjnolet commented Mar 14, 2023

@robertmaynard it looks like we are getting an error in CI related to the changes. Is there something else I need to set in order to make that work?

  Expression did not evaluate to a known generator expression

robertmaynard
robertmaynard requested changes Mar 15, 2023
View reviewed changes
cpp/CMakeLists.txt Outdated Show resolved Hide resolved
cjnolet and others added 2 commits March 15, 2023 11:01
@cjnolet
Copy link
Member Author

cjnolet commented Mar 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8b4d2e5 into rapidsai:branch-23.04 Mar 15, 2023
@cjnolet cjnolet deleted the build-2304-compiler_features branch March 15, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@cjnolet cjnolet

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjnolet @robertmaynard