-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raft: Build CUDA 12 packages #1388
Merged
rapids-bot
merged 76 commits into
rapidsai:branch-23.08
from
vyasr:feat/cuda12_nvidia_build
Jul 5, 2023
Merged
Changes from 12 commits
Commits
Show all changes
76 commits
Select commit
Hold shift + click to select a range
dd487ef
Switch to using cuda 12 workflows
vyasr 50d1576
Add nvcc flags needed to work with broken nvidia packages
vyasr 5502f75
Add a cuda11 compiler version and branch out the recipes
vyasr d88346e
Force build and test scripts to install rmm from the PR.
vyasr 6abba37
Fix dask branch
vyasr 6005851
Put back build deleted lines to see if it fixes CI
vyasr 925dac1
Add missing quotes
vyasr 823868c
Temporarily comment out all unnecessary builds
vyasr b88b5d0
Bifurcate all cuda deps by CUDA version
vyasr bc0bd39
Add cudart
vyasr a0ef11a
Make sure to hard pin the cuda versions during build
vyasr 60968ff
Update versions for 12.0.1 patch release of CUDA 12
vyasr f32bf15
Pin librmm
vyasr e7d204f
Fix libcusolver version
vyasr 6e5e321
Revert to 12.0.0 versions
vyasr 221b877
Add cuda runtime to build env for nvcc to see
vyasr 593619e
Add missing deps
vyasr ac329ff
Force using nvidia cublas
vyasr 9185552
Revert "Force using nvidia cublas"
vyasr 6952fc9
Try pinning cuda-version
vyasr 303f3dc
Fix spec
vyasr 3c7fa81
Revert "Fix spec"
vyasr bebd60c
Revert "Try pinning cuda-version"
vyasr f3761b8
Try reordering channels
vyasr 85d45fd
Fix indent
vyasr 0b26f47
Remove any hidden characters
vyasr 830fe9e
Use the correct root dir
vyasr a66d561
Remove faiss dependence
vyasr 1f7a69e
Remove faiss from bmarks
vyasr f1f61a8
Fix patched condarc
vyasr 5e00003
Disable faiss in a more elegant manner that still runs the tests on C…
vyasr 6445d04
Add CUDA 12 to dependencies.yaml for testing
vyasr 7bddaee
Add nvjitlink to run requirements for CUDA 12
vyasr 4031a66
Remove changes to pr.yaml
vyasr 349587f
Merge remote-tracking branch 'origin/branch-23.08' into feat/cuda12_n…
vyasr d391cd3
Merge branch 'branch-23.08' into feat/cuda12_nvidia_build
cjnolet cf1a793
ENH Remove NVCC temp flags and librmm CI channel
dantegd 34dbf37
ENH Update recipes meta
dantegd c15458a
FIX forgot to commit libraft meta changes
dantegd 9db2c1e
FIX Missing librmm line in libraft-headers meta section
dantegd 256d2c8
FIX Small fixes in libraft-headers section
dantegd 7a277ac
FIX Mode small fixes in libraft-headers section
dantegd 3377f1a
Fix maybe-uninitialized warning
tfeher 2b4f316
FIX remove not used variables
dantegd aec019c
FIX missing cuda-version specs in libraft recipe
dantegd f8db36b
Merge branch 'branch-23.08' into feat/cuda12_nvidia_build
dantegd 8a8b4ad
FIX remove unnecessary CUDA 12 library versions
dantegd 652f88e
FIX cudatoolkit specification fixes
dantegd 3790ecb
Apply suggestions from code review
dantegd 9dea87d
FIX thrust call
dantegd cd38bb2
FIX More review comments applied
dantegd f4f5a00
FIX rdg precommit
dantegd 6452dfb
FIX thrust call further fix
dantegd 4f27238
DBG Undo thrust changes to get a clean log
dantegd 446cb98
FIX remove cudart-static from dependencies of libraft-tests
dantegd c991324
DBG cudart dependency debugging
dantegd 4498951
DBG Fix faiss version to pull rapidsai channel package
dantegd b9913a4
FIX small cleanup
dantegd 821076d
FIX blank space in recipe
dantegd 127710f
FIX missing bracket
dantegd f6aa073
DBG sepcify cuda-version in run reqs of libraft artifact
dantegd ac5414d
DBG sepcify cuda-version in run reqs of ann bench artifact
dantegd a2d84d1
Apply suggestions from code review
dantegd 9ea3a4f
FIX More review comments applied
dantegd b3a4de8
FIX cuda compiler in conda_build_config
dantegd 47cb0fb
FIX typo in dependencies
dantegd 51255e8
Apply suggestions from code review
bdice 0f2549a
Apply suggestions from code review
dantegd 4dfaee3
Apply suggestions from code review
dantegd f3c482a
FIX More review comments applied
dantegd a3ba165
Update conda/recipes/raft-dask/meta.yaml
dantegd f15d380
FIX add ctk back to host of pylibraft and raft-dask
dantegd fa1d5b4
FIX changes from https://github.com/vyasr/raft/pull/1
dantegd fa45ec3
FIX remove unnecessary cuda libraries for libraft-tests and libraft-a…
dantegd f264b9b
Update conda/recipes/raft-dask/meta.yaml
dantegd 40417d9
Merge branch 'branch-23.08' into feat/cuda12_nvidia_build
cjnolet File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,19 @@ | ||
#!/bin/bash | ||
# Copyright (c) 2022, NVIDIA CORPORATION. | ||
# Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
bdice marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
set -euo pipefail | ||
|
||
source rapids-env-update | ||
|
||
export CMAKE_GENERATOR=Ninja | ||
|
||
RAPIDS_CUDA_MAJOR="${RAPIDS_CUDA_VERSION%%.*}" | ||
LIBRMM_CHANNEL=$(rapids-get-artifact ci/rmm/pull-request/1223/72e0c74/rmm_conda_cpp_cuda${RAPIDS_CUDA_MAJOR}_$(arch).tar.gz) | ||
|
||
rapids-print-env | ||
|
||
rapids-logger "Begin cpp build" | ||
|
||
rapids-mamba-retry mambabuild conda/recipes/libraft | ||
rapids-mamba-retry mambabuild --channel "${LIBRMM_CHANNEL}" conda/recipes/libraft | ||
|
||
rapids-upload-conda-to-s3 cpp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
#!/usr/bin/env bash | ||
# Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
|
||
export NVCC_PREPEND_FLAGS="${NVCC_PREPEND_FLAGS} -ccbin ${CXX}" # Needed for CUDA 12 nvidia channel compilers | ||
./build.sh libraft --allgpuarch --compile-lib --build-metrics --incl-cache-stats --no-nvtx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
#!/usr/bin/env bash | ||
# Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
|
||
export NVCC_PREPEND_FLAGS="${NVCC_PREPEND_FLAGS} -ccbin ${CXX}" # Needed for CUDA 12 nvidia channel compilers | ||
./build.sh libraft --allgpuarch --no-nvtx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
#!/usr/bin/env bash | ||
# Copyright (c) 2023, NVIDIA CORPORATION. | ||
|
||
export NVCC_PREPEND_FLAGS="${NVCC_PREPEND_FLAGS} -ccbin ${CXX}" # Needed for CUDA 12 nvidia channel compilers | ||
./build.sh tests bench-ann --allgpuarch --no-nvtx | ||
cmake --install cpp/build --component ann_bench |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
#!/usr/bin/env bash | ||
# Copyright (c) 2022-2023, NVIDIA CORPORATION. | ||
|
||
export NVCC_PREPEND_FLAGS="${NVCC_PREPEND_FLAGS} -ccbin ${CXX}" # Needed for CUDA 12 nvidia channel compilers | ||
./build.sh tests bench-prims --allgpuarch --no-nvtx | ||
cmake --install cpp/build --component testing |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that change was before I started working on the PR, I wonder if @ajschmidt8 might be able to help us here