-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using raft::resources
across raft::random
#1420
Using raft::resources
across raft::random
#1420
Conversation
…sources` instead of `raft::device_resources`
Thanks @cjnolet I'll try this out soon in cugraph-ops. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
I'll make sure I give a good heads up when these are finally removed. It's hard to explicitly deprecate everything individually but the general state of RAFT is that we're shifting the public APIs to the mdspan-based variants and raft::resources. It shouldn't be too complicated to shift over to the new APIs- mdspan is just a lightweight wrapper around a pointer w/ some shape information. I might submit a PR to cugraph-ops to attempt this change. |
/merge |
Eventually we need to do this across all the headers in the codebase so that users have a choice as to whether they want to use
raft::device_resources
(which implicitly depends on the cuda math libs and thrust) or whether they just want to useraft::resources
(which is agnostic of the resources it contains and allows the primitives themselves to levvy the dependency requirements).cc @MatthiasKohl this should allow cugraph-ops to completely remove the math libs dependency (though the conda recipes will also need to be changed to depend on
libraft-headers-only
and the cmake changed to turn off the CTK math libs dependency).NOTE: Before this PR is merged, it's important that it be tested w/ cugraph/cuml at the very least to spot any cases where the
device_resources.hpp
include was being assumed transitively from the RAFT functions.