Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python bindings for matrix::select_k #1422

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Add python bindings for matrix::select_k #1422

merged 3 commits into from
Apr 17, 2023

Conversation

benfred
Copy link
Member

@benfred benfred commented Apr 15, 2023

No description provided.

@benfred benfred requested review from a team as code owners April 15, 2023 05:45
@benfred benfred added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cpp CMake python labels Apr 15, 2023
@benfred benfred self-assigned this Apr 17, 2023
cjnolet
cjnolet approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really nice seeing all the hard work on the common pylibraft boilerplate paying off here. Even better seeing expansion of the Python APIs.

python/pylibraft/pylibraft/matrix/select_k.pyx Show resolved Hide resolved
python/pylibraft/pylibraft/test/test_select_k.py Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented Apr 17, 2023

/merge

@rapids-bot rapids-bot bot merged commit 574f8f8 into rapidsai:branch-23.06 Apr 17, 2023
@benfred benfred deleted the python_select_k branch April 17, 2023 21:36
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 18, 2023
@benfred @ahendriksen
Add python bindings for matrix::select_k (rapidsai#1422)
5e84daa 
Authors:
  - Ben Frederickson (https://github.com/benfred)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)

URL: rapidsai#1422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@benfred benfred

Labels
CMake cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benfred @cjnolet