Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pin_compatible to ensure that lower CTKs can be used #1462

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 25, 2023

The runtime requirement for the CTK is weaker than the build-time requirement. We allow installing raft into environments with an older CTK (any 11.x) than the build requirement (11.8)

@vyasr vyasr requested a review from a team as a code owner April 25, 2023 18:51
@vyasr vyasr self-assigned this Apr 25, 2023
@vyasr vyasr added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Apr 25, 2023
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Left one comment that we should investigate before I approve

conda/recipes/libraft/meta.yaml Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from a team as a code owner April 25, 2023 19:00
@github-actions github-actions bot added the cpp label Apr 25, 2023
@vyasr vyasr added 5 - DO NOT MERGE Hold off on merging; see PR for details and removed 3 - Ready for Review labels Apr 25, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Apr 25, 2023

Blocking while we discuss the appropriate dependency structure for the different packages.

Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr vyasr added 3 - Ready for Review and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Apr 25, 2023
@vyasr vyasr requested a review from ajschmidt8 April 25, 2023 21:20
conda/recipes/libraft/meta.yaml Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Apr 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit 1866120 into rapidsai:branch-23.06 Apr 25, 2023
@vyasr vyasr deleted the pin_compatible_ctk branch April 25, 2023 21:52
ahendriksen pushed a commit to ahendriksen/raft that referenced this pull request Apr 27, 2023
The runtime requirement for the CTK is weaker than the build-time requirement. We allow installing raft into environments with an older CTK (any 11.x) than the build requirement (11.8)

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Divye Gala (https://github.com/divyegala)
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Bradley Dice (https://github.com/bdice)

URL: rapidsai#1462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review bug Something isn't working cpp non-breaking Non-breaking change
Projects
Development

Successfully merging this pull request may close these issues.

5 participants