Test updates of CCCL (thrust, cub, libcudacxx) to 2.1.0. #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
cjnolet
added
5 - DO NOT MERGE
|
@bdice just checking in as I'm taking an inventory of open PRs for the 23.06 release. Is this PR still needed? |
|
Also responded offline -- tl;dr yes, we will need to work on this but I'm trying to fix up cudf's PR before making recommendations on how to address the device lambda issues for raft and other libraries. Target is |
bdice
force-pushed
the
cccl-update-2.1.0
branch
from
8f5b7ba to
d796a9f
Compare
|
cudf's CCCL update PR is fully working so I'm starting work on RAFT now. I'm planning to work on the build/CMake/conda/etc. side and get to a point where C++ is building with the right versions of CCCL. Once we see C++ failures (if any), I would like to pass this off to a RAFT dev so that I can continue setting up CCCL update PRs for other RAPIDS libraries. I can help identify the kinds of changes that might be needed -- let's see what fails and then I can advise accordingly. cc: @cjnolet |
bdice
force-pushed
the
cccl-update-2.1.0
branch
from
5610b98 to
3632934
Compare
bdice
force-pushed
the
cccl-update-2.1.0
branch
from
3632934 to
38d6753
Compare
|
CUDA 12 builds were failing with: Full error output: This is the same issue that was fixed in NVIDIA/libcudacxx#476, but that hasn't been released yet in CCCL 2.1.0. I tried to add a patch upstream in rapids-cmake for this issue in libcudacxx 2.1.0, but it's a pretty big patch (+866 / -888 lines) and didn't apply cleanly, so it might take a lot of manual reworking. We might be better served by going straight to CCCL 2.2.0 where this fix will land but that will require waiting for the 2.2.0 tag (coming soon?) as well as adopting changes in rapids-cmake to support the monorepo. Alternatively we might be able to pin to a commit hash of libcudacxx between releases 2.1.0 and 2.2.0 that includes these fixes. For now, I have added |
This was referenced Dec 7, 2023
Merged
|
Closing in favor of #2049. |
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 8, 2023
This PR is needed to change the one piece of RAFT that requires `cuda::proclaim_return_type` for compatibility with CCCL (Thrust) 2.2.0. This pulls out part of the diff of #1464, which we will be able to close in favor of a new PR after this is merged. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Divye Gala (https://github.com/divyegala) URL: #2048
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
This PR updates RAFT to CCCL 2.2.0. Do not merge until all of RAPIDS is ready to update. Depends on #2048. Replaces #1464. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Robert Maynard (https://github.com/robertmaynard) URL: #2049
ChristinaZ
pushed a commit
to ChristinaZ/raft
that referenced
this pull request
Jan 17, 2024
This PR updates RAFT to CCCL 2.2.0. Do not merge until all of RAPIDS is ready to update. Depends on rapidsai#2048. Replaces rapidsai#1464. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) - Robert Maynard (https://github.com/robertmaynard) URL: rapidsai#2049
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tests a rapids-cmake branch with CCCL (thrust, cub, libcudacxx) updated to 2.1.0. Do not merge this PR. The changes will be merged upstream in rapids-cmake after all libraries pass CI.