-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAGRA: Separate graph index sorting functionality from prune function #1471
CAGRA: Separate graph index sorting functionality from prune function #1471
Conversation
@tfeher Can you check the PR and let me know if there are any problems? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enp1s0 for the PR! It looks good overall, below you will find a few small comments (and just as a reference, I have also linked two existing issues).
@tfeher Thank you for your comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enp1s0 for addressing the issues. The PR looks good to me.
068d832
to
b447bdd
Compare
I have changed the test case parameters to satisfy the following requirements in int8 and uint8 tests. RAFT_EXPECTS(
dataset.extent(1) * sizeof(DataT) % 8 == 0,
"Dataset rows are expected to have at least 8 bytes alignment. Try padding feature dims."); |
/merge |
Changes
This PR separates the graph index sorting functionality from the CAGRA pruning function and creates a new function. (Related issue: #1446)
Unit test
I have included a new unit test for the sorting function. The test utilizes a separate dataset from the one used in the CAGRA main test to avoid the effect of rounding errors during norm computation between two vectors in the dataset. More details are in the source code.
https://github.com/enp1s0/raft/blob/ea6c449c260895e9125a591a4848eed06f5b72c4/cpp/test/neighbors/ann_cagra.cuh#L93-L96
Issue
Close #1446