Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify conda-cpp-post-build-checks #1935

Merged
merged 9 commits into from
Nov 9, 2023
Merged

Verify conda-cpp-post-build-checks #1935

merged 9 commits into from
Nov 9, 2023

Conversation

robertmaynard
Copy link
Contributor

Adds a CI check to verify the the libraft.so doesn't have any public weak kernel symbols.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Non-breaking change ci labels Oct 27, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner October 27, 2023 14:49
@github-actions github-actions bot removed the ci label Oct 27, 2023
@robertmaynard robertmaynard force-pushed the fea/add_ci_checks_for_kernel_visibility branch from f17f692 to 8d08192 Compare October 27, 2023 15:01
@robertmaynard robertmaynard force-pushed the fea/add_ci_checks_for_kernel_visibility branch 2 times, most recently from d076d6d to e7e4ecb Compare October 30, 2023 17:29
@robertmaynard @ajschmidt8
Ensure weak linking check runs on PR and nightly builds.
76433d1 
Co-authored-by: AJ Schmidt <ajschmidt8@users.noreply.github.com>
@robertmaynard robertmaynard force-pushed the fea/add_ci_checks_for_kernel_visibility branch from e7e4ecb to 76433d1 Compare October 30, 2023 18:38
@robertmaynard robertmaynard force-pushed the fea/add_ci_checks_for_kernel_visibility branch from 5c338f6 to c19d5f2 Compare October 30, 2023 23:30
ajschmidt8
ajschmidt8 approved these changes Nov 1, 2023
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

@cjnolet This introduces a new CI job that checks the libraft.so binary for public weak CUDA kernels. When one is found it will produce an error report so that the PR can be corrected before merging.

This ensures that the work done in #1898 doesn't regress when developers add new kernels.

@cjnolet
Copy link
Member

cjnolet commented Nov 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 9c38633 into rapidsai:branch-23.12 Nov 9, 2023
58 checks passed
@robertmaynard robertmaynard deleted the fea/add_ci_checks_for_kernel_visibility branch November 9, 2023 19:03
@bdice bdice mentioned this pull request Jan 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@robertmaynard robertmaynard

Labels
feature request New feature or request non-breaking Non-breaking change
Projects
VS/ML/DM Primitives Release Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @cjnolet @ajschmidt8