Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding NCCL clique to the RAFT handle #2431

Merged
merged 5 commits into from
Sep 26, 2024
Merged

Adding NCCL clique to the RAFT handle #2431

merged 5 commits into from
Sep 26, 2024

Conversation

viclafargue
Copy link
Contributor

No description provided.

@viclafargue viclafargue requested a review from a team as a code owner September 11, 2024 17:34
@github-actions github-actions bot added the cpp label Sep 11, 2024
@viclafargue viclafargue added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 19, 2024
cjnolet
cjnolet requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this change, Victor. The changes mostly look good, but I have very minor changes to naming (and filenames).

cpp/include/raft/comms/nccl_clique.cuh Outdated Show resolved Hide resolved
cpp/include/raft/comms/nccl_clique.cuh Outdated Show resolved Hide resolved
cpp/include/raft/core/device_resources.hpp Outdated Show resolved Hide resolved
cpp/include/raft/core/resource/nccl_clique_handle.hpp Outdated Show resolved Hide resolved
@cjnolet
Copy link
Member

cjnolet commented Sep 26, 2024

/merge

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (2e705fb) to head (b663890).
Report is 3 commits behind head on branch-24.10.

Additional details and impacted files 
@@              Coverage Diff              @@
##           branch-24.10    #2431   +/-   ##
=============================================
  Coverage         87.17%   87.17%           
=============================================
  Files                25       25           
  Lines               546      546           
=============================================
  Hits                476      476           
  Misses               70       70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rapids-bot rapids-bot bot merged commit b78a07d into branch-24.10 Sep 26, 2024
69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@viclafargue viclafargue

Labels
cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viclafargue @cjnolet @codecov-commenter