Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Hiding implementation details for distance primitives (dense + sparse) #344

Merged
merged 23 commits into from
Oct 22, 2021
Merged

[REVIEW] Hiding implementation details for distance primitives (dense + sparse) #344

merged 23 commits into from
Oct 22, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Sep 30, 2021

No description provided.

@cjnolet cjnolet added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change 2 - In Progress Currenty a work in progress labels Sep 30, 2021
@cjnolet cjnolet requested review from a team as code owners September 30, 2021 19:44
@github-actions github-actions bot added the cpp label Sep 30, 2021
@cjnolet cjnolet changed the title Hiding implementation details for distance primitives (dense + sparse) [WIP] Hiding implementation details for distance primitives (dense + sparse) Sep 30, 2021
@cjnolet cjnolet changed the title [WIP] Hiding implementation details for distance primitives (dense + sparse) [REVIEW] Hiding implementation details for distance primitives (dense + sparse) Oct 1, 2021
@cjnolet cjnolet added 3 - Ready for Review and removed 2 - In Progress Currenty a work in progress labels Oct 1, 2021
divyegala
divyegala approved these changes Oct 4, 2021
View reviewed changes
Copy link
Member

@divyegala divyegala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, pre-approving! Just pointing out a few more detail:: calls that aren't needed that I think got looked over in your latest commit

cpp/include/raft/distance/detail/canberra.cuh Outdated Show resolved Hide resolved
cpp/include/raft/distance/detail/chebyshev.cuh Outdated Show resolved Hide resolved
cpp/include/raft/distance/detail/correlation.cuh Outdated Show resolved Hide resolved
cpp/include/raft/distance/detail/cosine.cuh Outdated Show resolved Hide resolved
cpp/include/raft/distance/detail/euclidean.cuh Outdated Show resolved Hide resolved
cpp/include/raft/distance/detail/euclidean.cuh Outdated Show resolved Hide resolved
@cjnolet cjnolet mentioned this pull request Oct 12, 2021
Closed
@cjnolet
Copy link
Member Author

cjnolet commented Oct 12, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Oct 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ccba252 into rapidsai:branch-21.12 Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review cpp improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cjnolet @dantegd @divyegala