-
Notifications
You must be signed in to change notification settings - Fork 7
stop uploading packages to downloads.rapids.ai, update to 25.08 workflows #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| --disable-pip-version-check \ | ||
| -w "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" \ | ||
| . | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we don't upload the wheels, what do we put them now, just push them to pypi or directly or something after building them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're getting uploaded to the GitHub Actions artifact store.
via this:
Which gets called because we use it here:
rapids-cli/.github/workflows/pr.yaml
Lines 20 to 21 in 3ec5fc5
| build-wheel: | |
| uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.06 |
You can see those artifacts at the end of any CI run here, by scrolling down to the "Artifacts" section. For example, from this PR: https://github.com/rapidsai/rapids-cli/actions/runs/15287088447?pr=98
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes sense : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep no prob! Happy to answer any other question you have, there's a TON of indirection involved here.
ncclementi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
| --disable-pip-version-check \ | ||
| -w "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" \ | ||
| . | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that makes sense : )
Description
Contributes to rapidsai/build-planning#181
downloads.rapids.aishared-workflowsreferences tobranch-25.08, to pull in changes from Use GitHub Actions artifacts in Anaconda uploads shared-workflows#364Notes for Reviewers
How I identified changes
Looked for uses of the relevant
gha-toolstools, as well as documentation aboutdownloads.rapids.ai, being on the NVIDIA VPN, using S3, etc. like this:git grep -i -E 's3|upload|downloads\.rapids|vpn'How I tested this
See "How I tested this" on rapidsai/shared-workflows#364
Checklist