Skip to content

Conversation

@jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#181

Notes for Reviewers

How I identified changes

Looked for uses of the relevant gha-tools tools, as well as documentation about downloads.rapids.ai, being on the NVIDIA VPN, using S3, etc. like this:

git grep -i -E 's3|upload|downloads\.rapids|vpn'

How I tested this

See "How I tested this" on rapidsai/shared-workflows#364

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb requested a review from a team May 27, 2025 22:33
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 27, 2025
--disable-pip-version-check \
-w "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" \
.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't upload the wheels, what do we put them now, just push them to pypi or directly or something after building them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're getting uploaded to the GitHub Actions artifact store.

via this:

https://github.com/rapidsai/shared-workflows/blob/e62a069ab2266fa1508081ffff59869f68a78a33/.github/workflows/wheels-build.yaml#L249-L254

Which gets called because we use it here:

build-wheel:
uses: rapidsai/shared-workflows/.github/workflows/wheels-build.yaml@branch-25.06

You can see those artifacts at the end of any CI run here, by scrolling down to the "Artifacts" section. For example, from this PR: https://github.com/rapidsai/rapids-cli/actions/runs/15287088447?pr=98

Screenshot 2025-05-28 at 8 55 20 AM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense : )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep no prob! Happy to answer any other question you have, there's a TON of indirection involved here.

Copy link

@ncclementi ncclementi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

--disable-pip-version-check \
-w "${RAPIDS_WHEEL_BLD_OUTPUT_DIR}" \
.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that makes sense : )

@jameslamb jameslamb merged commit 71211f8 into rapidsai:main May 28, 2025
4 checks passed
@jameslamb jameslamb deleted the ci/stop-s3-uploads branch May 28, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants