rapids-cmake won't ever use an existing variable starting with RAPIDS_ #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
bug
vyasr
approved these changes
Jun 16, 2022
ajschmidt8
approved these changes
Jun 21, 2022
|
@gpucibot merge |
robertmaynard
added a commit
to robertmaynard/rapids-cmake
that referenced
this pull request
Sep 27, 2022
The changes in rapidsai#203 are meant to guard rapids-cmake from acting or behaving differently due to an existing variable prefixed with RAPIDS which causes un-intended code paths to be executed. In the case of `rapids_cython_create_modules` it is perfectly reasonable to have an output variable with the `RAPIDS` prefix. rapids-cmake won't execute differently due this variable being set before function execution.
rapids-bot bot
pushed a commit
that referenced
this pull request
Sep 27, 2022
The changes in #203 are meant to guard rapids-cmake from acting or behaving differently due to an existing variable prefixed with RAPIDS which causes un-intended code paths to be executed. In the case of `rapids_cython_create_modules` it is perfectly reasonable to have an output variable with the `RAPIDS` prefix. rapids-cmake won't execute differently due this variable being set before function execution. Authors: - Robert Maynard (https://github.com/robertmaynard) Approvers: - Vyas Ramasubramani (https://github.com/vyasr) URL: #276
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #200