Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json exclude flag behaves as expected libcudacx//thrust/nvcomp #223

Conversation

robertmaynard
Copy link
Contributor

This brings the behavior of the exclude flag inline with the behavior of EXCLUDE_FROM_ALL when provided to the add_subdirectory call.

…comp

This brings the behavior of the exclude flag inline with the
behavior of `EXCLUDE_FROM_ALL` when provided to the `add_subdirectory`
call.
@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jul 25, 2022
@robertmaynard robertmaynard requested a review from a team as a code owner July 25, 2022 19:20
@robertmaynard
Copy link
Contributor Author

This will help with packaging such as pip when we don't want any headers installed.

rapids-cmake/cpm/thrust.cmake Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Jul 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cf51b92 into rapidsai:branch-22.08 Jul 27, 2022
@robertmaynard robertmaynard deleted the exclude_json_flag_effect_install_rules branch July 27, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants