-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ninja
as build dependency
#301
Conversation
This PR adds `ninja` as a build dependency of `rapids-cmake`.
Did we want to add |
Good call, yes we do. |
hmmmm. something about the changes in this PR is making the test script take exponentially longer than it has in the past. here's an old run for comparison: |
I canceled the workflow for now to prevent wasting GPU resources since they're limited in GH Actions. we'll have to investigate why these changes are making things slower. |
Think |
As it turns out, the slowdown was caused by the CI image changes below. Adding EDIT --- I've also added the changes in 7fac4f5 to disable the |
@gpucibot merge |
Description
This PR adds
ninja
andmake
as build dependencies ofrapids-cmake
. Additionally, it disables thesccache
S3 backend for the c++ tests since compile times are negligible.Checklist
cmake-format.json
is up to date with these changes.include_guard(GLOBAL)
)