Upgrade spdlog to 1.10.0 #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull requests from external contributors require approval from a |
3 tasks
robertmaynard
added
feature request
|
/ok to test |
|
My plan is to merge this after rapidsai/rmm#1173 has been merged. If rmm is 'green' with 1.10 I see no problem updating spdlog for everyone else |
robertmaynard
approved these changes
Dec 2, 2022
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
Dec 2, 2022
Updates spdlog dependency to 1.10 to match the conda-forge pinning. Depends on rapidsai/rapids-cmake#312 Also updates the flake8 pre-commit hook location since it's migrated from gitlab to github. Authors: - Keith Kraus (https://github.com/kkraus14) Approvers: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) - AJ Schmidt (https://github.com/ajschmidt8) URL: #1173
|
RMM CI was green and I merged rapidsai/rmm#1173. I will merge this too. |
|
@gpucibot merge |
bdice
added a commit
to bdice/rapids-cmake
that referenced
this pull request
Dec 5, 2022
This reverts commit 4b079dc.
rapids-bot bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
This reverts commit 4b079dc. See rapidsai/rmm#1176 for details. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Ray Douglass (https://github.com/raydouglass) - Vyas Ramasubramani (https://github.com/vyasr) URL: #323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the default spdlog version to 1.10.0 to match the conda-forge pinning.
Checklist
cmake-format.jsonis up to date with these changes.include_guard(GLOBAL))