Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapids_test_install_relocatable tracks tests environment properties #390

Merged
merged 1 commit into from
Mar 23, 2023
Merged

rapids_test_install_relocatable tracks tests environment properties #390

merged 1 commit into from
Mar 23, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

Will allow projects to specify env variables on tests and have those recorded on the installed tests

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added feature request New feature or request non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Mar 22, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner March 22, 2023 15:15
vyasr
vyasr approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr vyasr changed the title rapids_test_install_relocatable tracks tests enviornment properties rapids_test_install_relocatable tracks tests environment properties Mar 22, 2023
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 623988d into rapidsai:branch-23.04 Mar 23, 2023
@robertmaynard robertmaynard deleted the install-tests-track-env-props branch March 23, 2023 13:20
robertmaynard added a commit to robertmaynard/rapids-cmake that referenced this pull request Mar 23, 2023
@robertmaynard
Revert "rapids_test_install_relocatable tracks tests environment prop…
a821e49 
…erties (rapidsai#390)"

This reverts commit 623988d.
rapids-bot bot pushed a commit that referenced this pull request Mar 23, 2023
@robertmaynard
Revert "install tests environment properties (#390)" (#391)
21b55df 
This reverts commit 623988d. Due to it not properly handling generator expressions in the new variables.

Authors:
  - Robert Maynard (https://github.com/robertmaynard)

Approvers:
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #391
@robertmaynard robertmaynard mentioned this pull request May 8, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @vyasr