Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested lib location for nvcomp #675

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

Modify rapids_cpm_nvcomp() to allow CMAKE_INSTALL_LIBDIR and CMAKE_INSTALL_INCLUDEDIR to be nested directories. This is needed to support building wheels that set these variables in order to put their libraries in their own package directory.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

Modify rapids_cpm_nvcomp() to allow CMAKE_INSTALL_LIBDIR and
CMAKE_INSTALL_INCLUDEDIR to be nested directories. This is needed
to support building wheels that set these variables in order to
put their libraries in their own package directory.
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner August 16, 2024 15:44
@KyleFromNVIDIA KyleFromNVIDIA added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 16, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 1f26d58 into rapidsai:branch-24.10 Aug 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants