Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures in cpm_generate_pins-nested tests #724

Merged
Next Next commit
Don't set always_download by default in package_details
vyasr committed Dec 4, 2024
commit 2f3e6295fdf537d5549ee319a6a5b507e08eec48
1 change: 0 additions & 1 deletion rapids-cmake/cpm/detail/package_details.cmake
Original file line number Diff line number Diff line change
@@ -92,7 +92,6 @@ function(rapids_cpm_package_details package_name version_var url_var tag_var sha
set(exclude_from_all OFF)
rapids_cpm_json_get_value(exclude_from_all)

set(always_download OFF)
if(override_json_data AND json_data AND git_details_overridden)
# `always_download` default value requires the package to exist in both the default and override
# and that the git url / git tag have been modified.