Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.8.0 #754

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Jan 28, 2025

This PR uses CUDA 12.8.0 to build and test.

xref: rapidsai/build-planning#139

@bdice bdice added non-breaking Introduces a non-breaking change improvement Improves an existing functionality DO NOT MERGE Hold off on merging; see PR for details labels Jan 28, 2025
@bdice bdice marked this pull request as ready for review January 28, 2025 15:58
@bdice bdice requested review from a team as code owners January 28, 2025 15:58
@bdice bdice requested review from gforsyth and removed request for a team January 28, 2025 15:58
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I don't see any other references that need to be updated.

Saw one C++ tests job failing, looks like a network problem to me.

CMake Error at /__w/rapids-cmake/rapids-cmake/rapids-cmake/cpm/detail/download.cmake:92 (message):
  CPM.cmake hash mismatch [got=d41d8cd98f00b204e9800998ecf8427e
  expected=6c9866a0aa0f804a36fe8c3866fb8a2c] to download details below

which results in a bunch of these further down:

CMake Error at /__w/rapids-cmake/rapids-cmake/build/cpm/cpm_nvbench-conda-makefile-build/_deps/rapids-cmake-src/rapids-cmake/cpm/find.cmake:189 (CPMFindPackage):
  Unknown CMake command "CPMFindPackage".

(build link)

Restarted CI to hopefully get past that.

@jameslamb jameslamb removed the request for review from gforsyth January 29, 2025 00:02
@bdice
Copy link
Contributor Author

bdice commented Jan 29, 2025

I think CI is failing for reasons unrelated to these changes. It's the CUDA 11.8 job that fails, and it has been retried 4 times. I hope it passes this time, but if not, we should probably try to reproduce locally.

@bdice bdice removed the DO NOT MERGE Hold off on merging; see PR for details label Jan 29, 2025
@vyasr
Copy link
Contributor

vyasr commented Jan 29, 2025

I wonder if CCCL (re)moved a tag or rewrote history or something like that to cause this.

@vyasr
Copy link
Contributor

vyasr commented Jan 29, 2025

Never mind, it passed now.

@vyasr
Copy link
Contributor

vyasr commented Jan 29, 2025

/merge

@rapids-bot rapids-bot bot merged commit 396d4c5 into rapidsai:branch-25.02 Jan 29, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants