[BUG] Conda package for rmm 24.04.00 clobbering files from fmt and spdlog #1528
Comments
cryos
added
? - Needs Triage
|
Thanks for filing this. We've been working on improving this systemically across RAPIDS, because this kind of issue pops up in several places. PR #1508 will help us identify issues like this and prevent them going forward. @AyodeAwe @jameslamb If you're able to collaborate on this effort, it would be a great help. I know both of you have expressed interest in this before. Also #1307 is relevant to this for CCCL (another set of headers that are clobbered by a few RAPIDS packages). |
|
Thanks for the |
|
I see that #1508 "contributes to" fixing this issue. What is needed to fully fix it? |
I'm still investigating that. By the time I move #1508 out of draft and put it up for review, hopefully we'll be able to change "contributes" to "fixes". Will post updates there as I go. |
|
Oh, I just realized it isn't currently in draft. That's an oversight... I just moved it there. |
|
Subscribe to rapidsai/build-planning#54 and rapidsai/build-planning#56 for updates. |
7 tasks
|
@jameslamb with rapidsai/rapids-cmake#689 and the RMM changes in #1678 is this one now resolved? |
|
@wence- no, this issue won't be resolved in 24.10. We ended up needing to take a patch on |
|
Thanks for the update, I'll move to 24.10 |
|
Blocked until we move everything to rapids-logger. See rapidsai/build-planning#104 |
I think this can be closed now as a result of #1808. The latest docker run \
--rm \
-it rapidsai/ci-conda:latest \
bash
conda install \
-c rapidsai-nightly \
--download-only \
'librmm=25.04.*' \
'rmm=25.04.*'cph list $CONDA_PREFIX/pkgs/librmm*.condalibrmm contents (click me)cph list $CONDA_PREFIX/pkgs/rmm*.condarmm contents (click me) |
|
We still need to do some work to make nvtx and CCCL stop being vendored (especially with the risk of clobbering for nvtx). I’ll open a new issue for those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Looking at
librmm-24.04.00-cuda12_240410_g8f19c9c3_0.tar.bzfrom the rapidsai conda channel I see multiple warnings about clobbered files fromfmtandspdlog.Steps/Code to reproduce bug
I downloaded https://anaconda.org/rapidsai/librmm/24.04.00/download/linux-64/librmm-24.04.00-cuda12_240410_g8f19c9c3_0.tar.bz2 and untarred, I see multiple files that are installed to paths that conflict such as
lib/libfmt.a,lib/libspdlog.a,include/fmt/color.h,include/spdlog/common.hthat cause conflicts.Expected behavior
The vendored files should be installed in paths that would not cause conflicts with other packages.
Environment details (please complete the following information):
The text was updated successfully, but these errors were encountered: