Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] librmm conda packages are shipping dependencies in the package #1833

Open
bdice opened this issue Feb 23, 2025 · 0 comments
Open

[BUG] librmm conda packages are shipping dependencies in the package #1833

bdice opened this issue Feb 23, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@bdice
Copy link
Contributor

bdice commented Feb 23, 2025

Currently, librmm is shipping headers and libraries from its dependencies. We need to clean this up so we don't clobber.

This issue is similar in flavor to rapidsai/cudf#13230.

I think this should be a prerequisite for #1779, to prevent the problem from getting worse.

rapids-logger

#1528 fixed librmm's clobbering of spdlog and fmt headers. However, we are now shipping rapids-logger headers and .so files that should just come from including rapids-logger as a dependency. This is a simple fix for the recipe, which I filed in #1834.

NVTX

For conda builds, NVTX should come from nvtx-c conda packages, rather than being CPM-fetched and shipped in include/nvtx3/ in the librmm package (which clobbers nvtx-c!). However, there is no CMake config being shipped with NVTX3 upstream, so we probably need to fix that first -- or provide our own CMake Find module so that it can be found locally. This may be a rapids-cmake project or a project for upstream NVTX. I filed an issue here: NVIDIA/NVTX#113

CCCL

We are shipping a vendored CCCL in librmm. We should probably transition this to use rapids_core_dependencies as proposed in #1307. I verified that this should contain the right files for our RAPIDS-vendored-CCCL installation, so the fix should be straightforward.

@bdice bdice added the bug Something isn't working label Feb 23, 2025
@bdice bdice self-assigned this Feb 23, 2025
rapids-bot bot pushed a commit that referenced this issue Feb 24, 2025
Fixes redistribution of `rapids-logger` code which can cause clobbering. See #1833.

After this change, the following paths should _not_ be in the `librmm` package:
- `lib/librapids_logger.so`
- `lib/cmake/rapids_logger/*`
- `include/rapids_logger/*`

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - https://github.com/jakirkham
  - Gil Forsyth (https://github.com/gforsyth)

URL: #1834
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: To-do
Development

No branches or pull requests

1 participant