Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing #include <rmm/detail/aligned.hpp> in pinned_memory_resource.hpp #848

Closed
huaouo opened this issue Aug 21, 2021 · 0 comments · Fixed by #852
Closed

[BUG] Missing #include <rmm/detail/aligned.hpp> in pinned_memory_resource.hpp #848

huaouo opened this issue Aug 21, 2021 · 0 comments · Fixed by #852
Assignees
Labels
bug Something isn't working

Comments

@huaouo
Copy link

huaouo commented Aug 21, 2021

Describe the bug

Hi,

I found that pinned_memory_resource.hpp referenced some functions in aligned.hpp as follows, but it didn't include aligned.hpp. Is this a bug or just excluded intentionally for some reason?

(detail::is_supported_alignment(alignment)) ? alignment : detail::RMM_DEFAULT_HOST_ALIGNMENT;
return detail::aligned_allocate(bytes, alignment, [](std::size_t size) {
void* p{nullptr};
auto status = cudaMallocHost(&p, size);
if (cudaSuccess != status) { throw std::bad_alloc{}; }
return p;
});

@huaouo huaouo added ? - Needs Triage Need team to review and classify bug Something isn't working labels Aug 21, 2021
@harrism harrism self-assigned this Aug 25, 2021
@harrism harrism removed the ? - Needs Triage Need team to review and classify label Aug 25, 2021
@rapids-bot rapids-bot bot closed this as completed in #852 Aug 30, 2021
rapids-bot bot pushed a commit that referenced this issue Aug 30, 2021
…ing (#852)

Adds missing includes of `rmm/detail/aligned.hpp` and `cstddef` wherever needed, and converts `size_t` to `std::size_t` thoughout RMM. A few other minor header ordering updates, and replacing quoted includes with angle bracket includes.

Fixes #848

Authors:
  - Mark Harris (https://github.com/harrism)

Approvers:
  - Rong Ou (https://github.com/rongou)
  - Conor Hoekstra (https://github.com/codereport)
  - Jake Hemstad (https://github.com/jrhemstad)

URL: #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants