Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new rapids-cython component of rapids-cmake to simplify builds #1031

Merged
merged 14 commits into from
May 11, 2022
Merged

Use new rapids-cython component of rapids-cmake to simplify builds #1031

merged 14 commits into from
May 11, 2022

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented May 4, 2022

The custom CMake code written in python/cmake has now been generalized and ported to rapids-cmake so that it can be shared across rapids libraries.

This PR depends on rapidsai/rapids-cmake#184 and tests will not pass until that is merged.

@vyasr vyasr added CMake 0 - Blocked Cannot progress due to external reasons non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 4, 2022
@vyasr vyasr self-assigned this May 4, 2022
@github-actions github-actions bot added the Python Related to RMM Python API label May 4, 2022
@vyasr
Copy link
Contributor Author

vyasr commented May 6, 2022

rerun tests

@vyasr vyasr marked this pull request as ready for review May 6, 2022 00:54
@vyasr vyasr requested review from a team as code owners May 6, 2022 00:54
bdice
bdice reviewed May 6, 2022
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a hook in the version updater script, but I think it's fine otherwise!

python/CMakeLists.txt Show resolved Hide resolved
python/CMakeLists.txt Show resolved Hide resolved
@github-actions github-actions bot added the gpuCI label May 7, 2022
@vyasr vyasr requested a review from a team as a code owner May 7, 2022 00:25
@vyasr vyasr added 3 - Ready for review Ready for review by team and removed 0 - Blocked Cannot progress due to external reasons labels May 7, 2022
ajschmidt8
ajschmidt8 approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

jakirkham
jakirkham approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Vyas and everyone for the reviews! 😄

@jakirkham
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4e8bca5 into rapidsai:branch-22.06 May 11, 2022
@vyasr vyasr deleted the feature/rapids-cython branch May 11, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice left review comments

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@jakirkham jakirkham jakirkham approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for review Ready for review by team CMake gpuCI improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to RMM Python API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @jakirkham @robertmaynard @bdice @ajschmidt8