Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle cudaMemHandleTypeNone and cudaErrorInvalidValue in is_export_handle_type_supported #1055

Merged
merged 4 commits into from
Jun 6, 2022
Merged

Properly handle cudaMemHandleTypeNone and cudaErrorInvalidValue in is_export_handle_type_supported #1055

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4860ebd
Don't throw on cudaErrorInvalidValue in is_export_handle_type_supported
gerashegalov Jun 1, 2022
87c0c2d
clang-format
gerashegalov Jun 1, 2022
b28c07e
Update include/rmm/detail/dynamic_load_runtime.hpp
gerashegalov Jun 1, 2022
4061aee
clang-format
gerashegalov Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions include/rmm/detail/dynamic_load_runtime.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,9 +136,18 @@ struct async_alloc {
{
int supported_handle_types_bitmask{};
#if CUDART_VERSION >= 11030 // 11.3 introduced cudaDevAttrMemoryPoolSupportedHandleTypes
RMM_CUDA_TRY(cudaDeviceGetAttribute(&supported_handle_types_bitmask,
cudaDevAttrMemoryPoolSupportedHandleTypes,
rmm::detail::current_device().value()));
if (cudaMemHandleTypeNone != handle_type) {
auto const result = cudaDeviceGetAttribute(&supported_handle_types_bitmask,
cudaDevAttrMemoryPoolSupportedHandleTypes,
rmm::detail::current_device().value());

// Don't throw on cudaErrorInvalidValue
auto const unsupported_runtime = (result == cudaErrorInvalidValue);
if (unsupported_runtime) return false;
// throw any other error that may have occurred
RMM_CUDA_TRY(result);
}

#endif
return (supported_handle_types_bitmask & handle_type) == handle_type;
}
Expand Down