Align __version__ with wheel version #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
reviewed
Nov 17, 2022
|
I also incorporated more suggestions from Lawrence in: rapidsai/ptxcompiler#31 |
sevagh
added
non-breaking
bdice
approved these changes
Nov 17, 2022
|
Just to note, I don't think it's critical at all, the "complain if set but empty" patch doesn't actually complain if the env var is empty. So in the very unlikely case that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the pip wheels, the versioneer version is overwritten with an env var,
RAPIDS_PY_WHEEL_VERSIONEER_OVERRIDEin the setup.py version.However, the
__version__metadata of the package doesn't match this override. This fix propagates the override to__version__also.